Add workaround for race condition
Audited560ecc8b90bc
Actions

Description

Add workaround for race condition

At the moment we rely on the 'webrtcup' Janus event for our 'established'
event. Turns out, this can be problematic, because on outgoing calls that can
come before the setRemoteDescription callback kicks in, which is where we
post the 'accepted' event. As a result, we get the state changes in the
incorrect order.

This is just a stopgap, a cleaner fix is needed.

Details

Auditors

tijmen

Provenance

saghul

Authored on Oct 12 2016, 7:47 AM

Parents

rSYLKRTCe485d0a0eaa2: Add ability to invite participants to a conference

Branches

Unknown

Tags

Unknown

Event Timeline

saghul committed rSYLKRTC560ecc8b90bc: Add workaround for race condition (authored by saghul).Oct 12 2016, 7:47 AM

This thing breaks outgoing calls. I get the event established, but inside current call the state is still accepted:

blinkrtc:App Call state changed! accepted -> established +11ms
Call.js:123 accepted
browser.js:112 sylkrtc:Call Stream added +9ms

Call.js:123 is where I print currentCall.state

This means we never transition from localMedia to VideoBox

tijmen added a subscriber: adigeo.Oct 17 2016, 2:47 PM

You are right. Pushed a new fixup commit, please test it out.

rSYLKRTC220abe444ee7: Fixup workaround for race condition fixed the thing!

Changes (1)

Path

Size

lib/

call.js

rSYLKRTC560ecc8b90bc

View Options